-
Notifications
You must be signed in to change notification settings - Fork 280
Add a plugins section to the README #1447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds a new Plugins section to the README with links to known plugins.
|
Linter errors are not related to this PR and can be fixed later. |
README.md
Outdated
| [`step-kms-proxy`] is also integrated directly into `step` to create | ||
| certificates, generate CSRs, sign tokens, and more using KMS-backed keys. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this go with the step-kms-plugin bullet? Or should it be step-kmsproxy-plugin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to do that but in markdown it goes to a new paragraph.
- step-kms-plugin data ta data da long line .... long line ... long line ... long line ... long line ... long line ... long line ... long line
This plugin is also integrated
- step-kmsproxy-plugin foo bar zar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But can't it be combined in the same bullet as step-kms-plugin, in a new sentence right after, by putting it on the same line? Or do you intentionally want this to be separate, because of the "integrated directly" being a more tight integration between step and the plugin? Even in that case, I think it'd be good to put it with the rest of the bullet, as this list could grow, and it being more out of context in that case.
Co-authored-by: Carl Tashian <carl@smallstep.com> Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
|
@maraino |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm

This commit adds a new Plugins section to the README with links to known plugins.
Fixes smallstep/step-kms-plugin#246