Skip to content

Conversation

@maraino
Copy link
Collaborator

@maraino maraino commented Jul 2, 2025

This commit adds a new Plugins section to the README with links to known plugins.

Fixes smallstep/step-kms-plugin#246

This commit adds a new Plugins section to the README with links to known
plugins.
@maraino maraino requested a review from tashian July 2, 2025 00:56
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 2, 2025
@maraino
Copy link
Collaborator Author

maraino commented Jul 2, 2025

Linter errors are not related to this PR and can be fixed later.

README.md Outdated
Comment on lines 99 to 100
[`step-kms-proxy`] is also integrated directly into `step` to create
certificates, generate CSRs, sign tokens, and more using KMS-backed keys.
Copy link
Member

@hslatman hslatman Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go with the step-kms-plugin bullet? Or should it be step-kmsproxy-plugin?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to do that but in markdown it goes to a new paragraph.

  • step-kms-plugin data ta data da long line .... long line ... long line ... long line ... long line ... long line ... long line ... long line

This plugin is also integrated

  • step-kmsproxy-plugin foo bar zar

Copy link
Collaborator Author

@maraino maraino Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in a new paragraph:
image

Copy link
Member

@hslatman hslatman Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But can't it be combined in the same bullet as step-kms-plugin, in a new sentence right after, by putting it on the same line? Or do you intentionally want this to be separate, because of the "integrated directly" being a more tight integration between step and the plugin? Even in that case, I think it'd be good to put it with the rest of the bullet, as this list could grow, and it being more out of context in that case.

Co-authored-by: Carl Tashian <carl@smallstep.com>
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
@maraino maraino requested review from hslatman and tashian July 2, 2025 17:31
@hslatman
Copy link
Member

hslatman commented Jul 8, 2025

@maraino this likely needs a rebase. Renamed the bcrypt package. That was in crypto.

@hslatman hslatman added this to the v0.28.7 milestone Jul 9, 2025
@hslatman
Copy link
Member

hslatman commented Jul 9, 2025

Linter issue is fixed in #1448. @tashian if you're OK with the changes, then this can be merged after rebasing on top of it.

Copy link
Contributor

@tashian tashian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraino maraino merged commit 632b477 into master Jul 9, 2025
12 of 13 checks passed
@maraino maraino deleted the mariano/plugin branch July 9, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We built an authenticating proxy that integrates with step-kms

3 participants